Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update outdated dev dependencies #164

Merged
merged 1 commit into from
Jul 8, 2019

Conversation

posquit0
Copy link
Contributor

@posquit0 posquit0 commented Jul 7, 2019

I upgraded some development dependencies. All test passed with yarn test and yarn test:lint.

@kalinchernev
Copy link
Contributor

Hi @posquit0 and thanks for the updates! Please remove the tilde (^) from the versions, they are intentionally left out because I am not the guy to debug issues with loose dependencies. Takes extremely much time to find issues and tell people consistently to delete node_modules folder when issues are simply because of mixtures of versions because of the loose "^".

@posquit0
Copy link
Contributor Author

posquit0 commented Jul 7, 2019

I did! Thanks for your feedback. :)

@kalinchernev
Copy link
Contributor

@posquit0 thanks for the updates! Could you please run yarn on clean state (no node_modules).
There seemed to be a difference between your current code with versions and the lock file. Like this:

yarn.lock.zip (please don't apply as patch :) it's just for demoing the difference)

Would you mind also removing the "precommit": "lint-staged" line from the package.json file? It's not related to your changes, but seeing the upgrade of husky I noticed that hasn't been removed in the update of pre v1 to current one :)

@posquit0
Copy link
Contributor Author

posquit0 commented Jul 7, 2019

I updated my commit with your feedback! :)

@kalinchernev kalinchernev merged commit b472303 into Surnet:master Jul 8, 2019
@kalinchernev
Copy link
Contributor

@posquit0 thanks! :)

@posquit0 posquit0 deleted the udpate-dev-deps branch July 8, 2019 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants