Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include .yaml, and able to define responses, parameters and securityDefinitions #15

Merged
merged 4 commits into from
Feb 26, 2016
Merged

Conversation

efmr
Copy link
Contributor

@efmr efmr commented Feb 5, 2016

Document responses, parameters and securityDefinitions in a similar fashion as for definitions.
Able to include directly yaml files as apis (that will be merged with the jsdoc comments).
Tests included, but increased max statements from 15 to 18 and max complexity from 6 to 8 to pass the jshint test.

@chdanielmueller
Copy link
Member

Hey @efmr.
I will take a look at this and merge it if I don't find any problems.
I hope I can give you a feedback in the next week. (I'm on a tight schedule at the moment)
@drGrove: Or would you like to check this addition to the project?
Regards,
Daniel

@drGrove
Copy link
Contributor

drGrove commented Feb 10, 2016

@chdanielmueller: Busy week myself but should have some time in the next couple of days. I am more than happy to look at it though

@drGrove
Copy link
Contributor

drGrove commented Feb 17, 2016

👍
Looks good. Actually ran it against some code i'm working on with securityDefinitions and replaces the code i was working on.

@chdanielmueller Looks good to merge

chdanielmueller added a commit that referenced this pull request Feb 26, 2016
Include .yaml, and able to define responses, parameters and securityDefinitions
@chdanielmueller chdanielmueller merged commit 0303dd1 into Surnet:master Feb 26, 2016
@chdanielmueller
Copy link
Member

@efmr: Sorry for taking so long to merge this.
It is now published an available in v1.2.0 on npm.

@chdanielmueller
Copy link
Member

@drGrove: Thanks for testing this out!

@drGrove
Copy link
Contributor

drGrove commented Feb 26, 2016

@chdanielmueller: Not a problem! Let me know if you need anything else.

@efmr
Copy link
Contributor Author

efmr commented Feb 27, 2016

@chdanielmueller no problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants