-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.10.2 #120
Release 1.10.2 #120
Conversation
@kalinchernev |
Agree. It's strange to me too seeing requests to remove the CLI out of the package to reduce size.
After:
PS: The CLI is 5kb, hopefully the 2.4kb is ok of an optimisation for now. |
I think it's not because of the package size itself but the dependency to node-gyp. see #92 |
@chdanielmueller what is your suggestion about it? Shall I remove it out of the package? |
First: It's up to you ;) I would suggest to remove it in swagger-jsdoc and create a new package swagger-jsdoc-cli which depends on swagger-jsdoc. |
@chdanielmueller not only up to me, that's why I'm asking :) However, I'm hesitating on the thought, as if there is any of the 62 dependent packages using the CLI, they will fail. I also imagine many use the package as a part of an automation pipeline, which could be even worse to break without a warning. At the same time, there's https://www.npmjs.com/package/swagger-jsdoc-generator already. The only benefit of someone to use swagger-jsdoc-cli and not swagger-jsdoc-generator would be the watch task. Another idea would be to remove chokidar. This way we remain compatible for all dependent packages and hopefully remove the problem with the node-gyp. Then, if watch mode is so missed, someone will open an issue and we'll point him to the chokidar package to solve the problem by himself, if one hasn't done so yet. |
Yeah if you are able to remove chokidar without removing the cli completely that sounds like the best option to me. |
@kalinchernev Maybe @lmammino is interested to implement the watch mode to lmammino/swagger-jsdoc-generator for those missing the feature. |
No description provided.