Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining Python 3 compatibility issues #1029

Merged
merged 9 commits into from
Dec 17, 2017
Merged

Fix remaining Python 3 compatibility issues #1029

merged 9 commits into from
Dec 17, 2017

Conversation

mnaberez
Copy link
Member

This pull request applies a patch submitted by @vsajip that overhauls bytes/strings handling inside supervisord to fix all of the open Python 3 issues. Test cases are included for all of those issues.

Closes #471
Closes #565
Closes #638
Closes #663
Closes #664
Closes #835
Closes #836
Closes #974

Thank you @vsajip!

@mnaberez mnaberez merged commit 7da10a8 into Supervisor:master Dec 17, 2017
@mnaberez mnaberez deleted the py3-compat branch December 17, 2017 02:22
@Lucretiel
Copy link

🥇 🎆 🎉

@ciarancourtney
Copy link

7da10a8 seems good to me during quick testing on python3.6, when can we expect the 4.0 release?

@zjjott
Copy link

zjjott commented Dec 26, 2017

nice!

@cclauss
Copy link
Contributor

cclauss commented Dec 29, 2017

Just this repo, httplib2, and the Mozilla build tools left on https://python3wos.appspot.com

@ibnbay00
Copy link

When version 4 is release or version to support python 3...? 👍

@waldyrious
Copy link

Just this repo, httplib2, and the Mozilla build tools left on python3wos.appspot.com

FYI, httplib2 is no longer there since v0.11.0 (released 2 days ago): httplib2/httplib2#50 (comment)

findepi added a commit to findepi/docker-images that referenced this pull request Apr 8, 2019
`supervisord` drop support for Python 2.6 in
Supervisor/supervisor#1029
findepi added a commit to trinodb/docker-images that referenced this pull request Apr 8, 2019
`supervisord` drop support for Python 2.6 in
Supervisor/supervisor#1029
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment