-
-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework shard behavior #3170
base: master
Are you sure you want to change the base?
Rework shard behavior #3170
Conversation
@Rusty-Box : Please give it a try and check if this works better. |
Haven't tested yet but in my opinion the crystallo shards should retain their current behavior but every single other usages of darts can have this shattering-upon-impact. |
Nice. Make sure this works with the corrupted big granito, roof crystallo, and corrupted igel. |
In my opinion the cooldown should stay but instead be significantly lowered to something like less than a second. This PR might need discussion |
They all use the same class, so it works for all of them.
Sure, I absolutely agree about the discusison. |
* Decrease time the shards are active * Fadeout shards when becoming inactive Fixes SuperTux#3134
dd6b114
to
ec48e26
Compare
No feedback yet, so I give you the opportunity to try it out. Shards remain for 0.7 seconds active after impact and fadeout in another 0.3 seconds (not hurting anymore). This feels quite fair for me and looks nicer. |
Fixes #3134