Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework shard behavior #3170

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Brockengespenst
Copy link
Contributor

@Brockengespenst Brockengespenst commented Jan 10, 2025

  • Decrease time the shards are active
  • Fadeout shards when becoming inactive

Fixes #3134

@Brockengespenst
Copy link
Contributor Author

@Rusty-Box : Please give it a try and check if this works better.

@weluvgoatz
Copy link
Member

Haven't tested yet but in my opinion the crystallo shards should retain their current behavior but every single other usages of darts can have this shattering-upon-impact.

@MatusGuy
Copy link
Member

Nice. Make sure this works with the corrupted big granito, roof crystallo, and corrupted igel.

@MatusGuy
Copy link
Member

In my opinion the cooldown should stay but instead be significantly lowered to something like less than a second. This PR might need discussion

@MatusGuy MatusGuy added type:patch involves:functionality status:needs-discussion Team member and developers need to discuss of decisions category:code labels Jan 10, 2025
@Brockengespenst
Copy link
Contributor Author

Brockengespenst commented Jan 10, 2025

Nice. Make sure this works with the corrupted big granito, roof crystallo, and corrupted igel.

They all use the same class, so it works for all of them.

In my opinion the cooldown should stay but instead be significantly lowered to something like less than a second. This PR might need discussion

Sure, I absolutely agree about the discusison.
If keeping the old behaviour, I think decreasing the time the shards are still active should definitely be decreased. And maybe add some decent fade out effect instead of disappearing instantly.

* Decrease time the shards are active
* Fadeout shards when becoming inactive

Fixes SuperTux#3134
@Brockengespenst Brockengespenst force-pushed the shatter_shards_on_impact branch from dd6b114 to ec48e26 Compare January 11, 2025 22:42
@Brockengespenst
Copy link
Contributor Author

Brockengespenst commented Jan 11, 2025

No feedback yet, so I give you the opportunity to try it out. Shards remain for 0.7 seconds active after impact and fadeout in another 0.3 seconds (not hurting anymore). This feels quite fair for me and looks nicer.
Further idea: Fadout may already start on first impact with Tux or a badguy - kind of "taking the shard out of the game" after first hit of one of them.

@Brockengespenst Brockengespenst changed the title Shatter shards on impact Rework shard behavior Jan 11, 2025
@Alasdairbugs Alasdairbugs self-requested a review January 17, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:code involves:functionality status:needs-discussion Team member and developers need to discuss of decisions type:patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shards should shatter upon impact
3 participants