Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMakeLists.txt to enable GLM Experimental #1810

Closed
wants to merge 1 commit into from
Closed

Update CMakeLists.txt to enable GLM Experimental #1810

wants to merge 1 commit into from

Conversation

christianhaitian
Copy link

Build fails on Debian Buster without these entries for either Release or Debug builds.

or build fails on Debian Buster
@tobbi
Copy link
Member

tobbi commented Aug 29, 2021

In file included from /home/runner/work/supertux/supertux/src/audio/sound_manager.hpp:28:0,
                 from /home/runner/work/supertux/supertux/src/audio/openal_sound_source.cpp:19:
/home/runner/work/supertux/supertux/src/math/vector.hpp:20:0: error: "GLM_ENABLE_EXPERIMENTAL" redefined [-Werror]
 #define GLM_ENABLE_EXPERIMENTAL

Probably needs an #ifndef. Can you fix that as well?

@Grumbel
Copy link
Member

Grumbel commented Aug 29, 2021

Probably best to remove the #define GLM_ENABLE_EXPERIMENTAL from all the source and switch to just compiler flags.

-D GLM_ENABLE_EXPERIMENTAL shouldn't have a space.

@christianhaitian
Copy link
Author

It compiled fine on my end with that inclusion as shown in the commit but I don't know what the implications are for non debian/ubuntu systems. If there's a more efficient solution for this that allows building on debian/ubuntu, I am in full support.

@Grumbel
Copy link
Member

Grumbel commented Oct 8, 2021

Fixed with b320c27

@Grumbel Grumbel closed this Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants