Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ubports mk dir to clickable #1766

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Conversation

jonnius
Copy link
Contributor

@jonnius jonnius commented Jun 16, 2021

UBports is the name of the foundation which should not be used for referring to the OS, which is Ubuntu Touch.

@Semphriss
Copy link
Member

If it's going to be renamed, it should be renamed to "clickable" instead, given that the configuration is specific to clickable.

@jonnius
Copy link
Contributor Author

jonnius commented Jun 17, 2021

I find it a bit surprising to name it after the tool rather than the target, but I changed it accordingly.

@Semphriss
Copy link
Member

My usual logic to name workflow it according to the most specific thing it is designed for. For example, the workflow for Linux/macOS isn't specific to a single compiler (it isn't even a single OS - FreeBSD would be there too if GitHub offered it directly). That's why it's named "Unix".

For Ubuntu Touch, the workflow is designed to work specifically with Clickable; if there is any other framework/toolchain/etc., it would need its own workflow. (I'm not aware of any framework for UT other than Clickable - are there more?)

Also - did you push?

@jonnius
Copy link
Contributor Author

jonnius commented Jun 17, 2021

I pushed to the wrong branch before 🤦🏽

Clickable is a tool to facilitate cross-compiling and packaging click packages for Ubuntu Touch. The packaging itself is done by the tool click. Ubuntu Touch is not like a traditional distro. It rather defines the framework apps can expect. Clickable provides docker images based on that framework coming from the Ubuntu Touch repositories provided by UBports.

In theory, Clickable could be used to build packages for other systems. But as this is not the case, Clickable is more specific than Ubuntu Touch.

@tobbi tobbi merged commit f6954d5 into SuperTux:master Jun 29, 2021
@jonnius jonnius changed the title Rename ubports mk dir to ubuntu-touch Rename ubports mk dir to clickable Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants