Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windowsdylan icecrash patch #1658

Merged
merged 2 commits into from
Feb 6, 2021

Conversation

windowsdylan
Copy link
Contributor

Shortened the icecrash sound so when the stalactite falls, the sound plays at the exact time it hits the ground.

@tobbi
Copy link
Member

tobbi commented Jan 27, 2021

[ci skip] ? 😛

@windowsdylan
Copy link
Contributor Author

[ci skip] ? 😛

Huh?

@Semphriss
Copy link
Member

@windowsdylan Add "ci skip" to your commit messages so that the build system won't waste time rebuilding the entire game only for an asset change

@Ordoviz
Copy link
Contributor

Ordoviz commented Jan 28, 2021

It’s also a good idea to squash the commits together under a meaningful description like: “[ci skip] Shorten icecrash sound”. However, as @windowsdylan is clearly new to Git, the maintainers should do this.

@serano01 serano01 merged commit c54014a into SuperTux:master Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants