Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low trampoline jumps #1656

Closed
HybridDog opened this issue Jan 25, 2021 · 2 comments · Fixed by #1769
Closed

Low trampoline jumps #1656

HybridDog opened this issue Jan 25, 2021 · 2 comments · Fixed by #1769

Comments

@HybridDog
Copy link
Contributor

HybridDog commented Jan 25, 2021

SuperTux version: supertux2 v0.6.2-614-gd86dae0e9
System information: Lubuntu 18.04

Expected behavior

When holding the jump button, Tux should always jump high after landing on a trampoline.

Actual behavior

When I hold the jump button shortly before Tux lands on the trampoline, he jumps only a low height.

Here is a video of the problem. To hear the sound you may need to download the video.

Steps to reproduce actual behavior
  • Jump from a solid tile so that Tux will eventually land on a trampoline
  • Release the jump button mid-air
  • Shortly before landing on the trampoline, press and hold the jump button
Additional debugging information

As far as I know, there's a feature which lets Tux jump off solid ground if the player presses and holds the jump button shortly before landing. Perhaps the implementation of this feature conflicts with the high trampoline jumps.

If I remember correctly, there may be another old issue about this problem which is closed now.

kmatebotond added a commit to kmatebotond/supertux that referenced this issue Jun 25, 2021
@Alasdairbugs
Copy link
Contributor

i dont think this is a bug. you just need to start holding jump 3-4 tiles from falling onto a spring, its actually extremely consistent. maybe this should be changed to give some "coyote time" but this is not necessarily a bug.

@HybridDog
Copy link
Contributor Author

It's not consistent. Low trampoline jumps can only happen after jumping from solid ground or after falling from a previous low trampoline jump; if I jump on a trampoline, then let Tux bounce without holding jump and then let him bounce again while holding jump just before landing, the low trampoline jump doesn't happen. (I forgot to write this in the issue description)

I personally don't like this low trampoline jump behaviour because it's complicated and while playing it doesn't let me quickly re-decide how high Tux should jump.

tobbi pushed a commit that referenced this issue Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants