Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assets实现flavor分化及其它一些优化 #178

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

LZX284
Copy link
Contributor

@LZX284 LZX284 commented Nov 14, 2023

因同步最新修改时存在冲突,因此作了一些调整……
@SuperMonster003
先就这样吧,Assets目录分化设置先保留,文件未移动,不会对目前的打包功能产生实际影响。至于是否采用,你可以按自己的偏好进行选择

Assets按flavors分化为三个目录
@LZX284 LZX284 reopened this Nov 15, 2023
@SuperMonster003 SuperMonster003 merged commit afc0bce into SuperMonster003:master Nov 16, 2023
2 checks passed
@SuperMonster003
Copy link
Owner

从邮件里找到一些关于之前丢失且未合并 PR 的线索 (9f9e2f3 / 060e1cf), 在此贴出来, 不希望因自己的失误而埋没贡献者的辛苦付出.

我会从之前提交记录中试图恢复贡献者的代码到后续版本中, 并在必要的地方标注贡献者信息.

感谢 LZX284 对项目的贡献.

以下为邮件中恢复的相关信息.


AI Unsubscribe | AI Unsubscribe | Wed, Nov 8, 3:49 PM (8 days ago) -- | -- | -- AI Unsubscribe AI Unsubscribe

Wed, Nov 8, 3:49 PM (8 days ago)

to LZX284/AutoJs6, me, Mention

大致实现了Assets目录的flavor分化,共同的文件放在main中,其它的存放于各自的assets目录里,避免因为assets文件混在一起导致打包模板体积过大 @SuperMonster003 这个PR只是提供一个思路(不会有后续提交了),如果与你当前修改有冲突,你也可以做个简单的说明并关闭它。另外就是如果没什么特殊情况,建议审核PR的时间不宜过长,比如不要超过一个月,因为时间太长的话即使有什么好的想法也可能早都忘光光了,那样体验可能就不那么好了


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.


AI Unsubscribe | AI Unsubscribe | Wed, Nov 8, 8:36 AM (8 days ago) -- | -- | -- AI Unsubscribe AI Unsubscribe

Wed, Nov 8, 8:36 AM (8 days ago)

to SuperMonster003/AutoJs6, Subscribed

Open Chinese Convert(OpenCC)是一个开源的中文简繁转换项目,致力于制作高质量的基于统计预料的简繁转换词库。还提供函数库(libopencc)、命令行简繁转换工具、人工校对工具、词典生成程序、在线转换服务及图形用户界面。
引入的依赖出自Github项目:android-opencc
You can view, comment on, or merge this pull request online at:

https://github.com/SuperMonster003/AutoJs6/pull/169
Commit Summary

b9f65cf 引入OpenCC依赖

File Changes

(1 file)

M app/build.gradle.kts (6)

Patch Links:

https://github.com/SuperMonster003/AutoJs6/pull/169.patch
https://github.com/SuperMonster003/AutoJs6/pull/169.diff


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.


AI | AI | Wed, Nov 8, 3:49 PM (8 days ago) -- | -- | -- AI AI

Wed, Nov 8, 3:49 PM (8 days ago)

to Push, SuperMonster003/AutoJs6

@LZX284 pushed 1 commit.

9f9e2f3 Assets目录的flavor分化


View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.


AI Unsubscribe | AI Unsubscribe | Wed, Nov 8, 3:58 PM (8 days ago) -- | -- | -- AI Unsubscribe AI Unsubscribe

Wed, Nov 8, 3:58 PM (8 days ago)

to SuperMonster003/AutoJs6, Push

@LZX284 pushed 1 commit.

060e1cf 修复一个小问题


View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.


AI | AI | Wed, Nov 8, 4:08 PM (8 days ago) -- | -- | -- AI AI

Wed, Nov 8, 4:08 PM (8 days ago)

to Mention, SuperMonster003/AutoJs6, me

@SuperMonster003
这个PR只是为解决@diuchouni 提出的问题打包出来一堆没用的东西提供一个解决思路以供参考(不会有后续提交了),如果与你的最新修改有冲突的话就算了。


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.


SuperMonster003 | SuperMonster003 | Tue, Nov 14, 5:27 PM (2 days ago) -- | -- | -- SuperMonster003 SuperMonster003

Tue, Nov 14, 5:27 PM (2 days ago)

to Your, SuperMonster003/AutoJs6, me

@LZX284
L 大提交的 PR #169 因为我没有合并, 导致在 rebase 的时候自动消失了. [ 哭 ]
第一次 rebase, git 也不熟练, 看到 PR 丢了好心痛. 麻烦 L 大再提交一次 PR 吧.

Sent from my XQ-DQ72 using FastHub


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.


AI | AI | Tue, Nov 14, 11:38 PM (2 days ago) -- | -- | -- AI AI

Tue, Nov 14, 11:38 PM (2 days ago)

to Mention, SuperMonster003/AutoJs6, me

@SuperMonster003
PR #178 已提交,其它方面,有一些说明写在代码注释里,另外就是内置的template一般不要选择体积最大的universal版,建议可以内置最通用的arm64-v8a版,其它架构的模板包可以和app一起发布到Releases页面(打包时通过外置方式调用)


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.

@SuperMonster003
Copy link
Owner

通过应用设置页面, 长按 "关于应用与开发者", 点击 "加入群组", 可加入 AutoJs6 交流群.

随时欢迎.

@LZX284
Copy link
Contributor Author

LZX284 commented Nov 16, 2023

通过应用设置页面, 长按 "关于应用与开发者", 点击 "加入群组", 可加入 AutoJs6 交流群.

@SuperMonster003
呜,下午刚加的群,没想到晚上就被腾讯以违规理由冻结了,算了,有问题还是GitHub上说,或者你也可以去问 Tony 大佬,他的建议其实都很中肯,可以帮你省下不少麻烦。

@SuperMonster003
Copy link
Owner

@LZX284 好的, 没问题.

Sent from my XQ-DQ72 using FastHub

@LZX284 LZX284 mentioned this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants