Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline work #490

Merged
merged 10 commits into from
Dec 16, 2024
Merged

Pipeline work #490

merged 10 commits into from
Dec 16, 2024

Conversation

brifordwylie
Copy link
Member

Pull Request Checklist

Thank you for contributing to the SuperCowPowers SageWorks project. Please make sure you've completed the following tasks before submitting your pull request:

GENERAL

  • [ ] I've read the CONTRIBUTING document.
  • [ ] I've merged 'main' into my PR branch (like today's main)

TESTING (run 'tox' for local testing)

  • [ ] I've added tests to cover my changes
  • [ ] black/flake8 linter tests passed
  • [ ] 100% of the tests passed

UI (Web Interface/Components)

  • [ ] I've run sageworks/applications/aws_dashboard/dashboard
  • [ ] I've tested the UI and scanned the log output for any issues

DOCUMENTATION

  • [ ] I've updated the documentation accordingly

REVIEW

  • [ ] I've added (or will add) a reviewer to the PR
  • [ ] I'll address any comments/request from reviewer
  • [ ] I will delete the branch after the PR is merged

Notes

An SCP Developer/reviewer may make direct changes to your branch. A follow up issue might be created or asked for. Branches are empheral, they should/will be deleted after the PR is merged. Do not reuse an old branch, if a change needs to be made pull a new branch off of main.

Description of Changes

Copy link
Member Author

@brifordwylie brifordwylie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brifordwylie brifordwylie merged commit 3073ebd into main Dec 16, 2024
5 checks passed
@brifordwylie brifordwylie deleted the pipeline_work branch December 16, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant