Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove EntangledSpinWaveTheory #354

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove EntangledSpinWaveTheory #354

wants to merge 1 commit into from

Conversation

ddahlbom
Copy link
Member

@ddahlbom ddahlbom commented Feb 9, 2025 •
edited
Loading

Setting up a PR to keep track of necessary steps to complete the initial version of "Entangled Units."

  • Make EntangledSpinWaveTheory a regular SpinWaveTheory and eliminate associated code duplication.
  • To facilitate the above, update intensities calculations to incorporate offsets from the MeasureSpec.
  • Consider revision of SampledCorrelations to follow similar model (and eliminate fields added to supported entangled units).
  • Correct treatment of g-factors from original system.
  • Add stronger tests for Entangled Units spin wave theory, in particular with attention to reshaping and non q=0 orderings.

A related issue, which may not be for this PR, is to extend the EntangledSystem constructor to deal with inhomogenous systems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ddahlbom