Issue #SB-28247 fix:QA issues fixed #8248
Conversation
| @@ -1192,7 +1192,7 @@ frmelmnts.lbl.switchToJoyLayout=Switch to joyful theme | |||
| frmelmnts.lbl.switchToOldLayout=Switch to classic theme | |||
| frmelmnts.lbl.switchUser=Change user | |||
| frmelmnts.lbl.tableNotAvailable=Table view is not available for this report | |||
| frmelmnts.lbl.table = Table | |||
There was a problem hiding this comment.
is this already existing one?
anywhere else is it used before can you check
There was a problem hiding this comment.
No it is not, i had added this during the Program dashboard table feature development
| @@ -21,7 +21,7 @@ | |||
| <!-- title --> | |||
| <h4 class="textbook__title sb-color-primary font-weight-bold mt-8 ml-24" >{{resourceService?.frmelmnts?.lnk?.programDashboard}}</h4> | |||
| <div> | |||
| <button class="sb-btn sb-btn-primary sb-btn-normal px-24" (click)="goBack()"> | |||
There was a problem hiding this comment.
why function name change?
| @@ -9,7 +9,7 @@ | |||
| <div class="mr-12"> | |||
| <button type="button" [ngClass]="layoutConfiguration ? 'sb-btn-round' : ''" | |||
| class="sb-btn sb-btn-normal sb-btn-link sb-btn-link-primary sb-left-icon-btn px-0" tabindex="0" | |||
| (click)="goBack()" id="goBack" attr.aria-label="{{resourceService?.frmelmnts?.btn?.back}}"> | |||
| (click)="closeDashboard()" id="goBack" attr.aria-label="{{resourceService?.frmelmnts?.btn?.back}}"> | |||
There was a problem hiding this comment.
why function name change?
There was a problem hiding this comment.
A new function has been added specific for going back to previous location and closing the dashboard previous function goBack is related to filter pop-up closing functionality based on few scenarios
| @@ -273,7 +275,7 @@ export class DatasetsComponent implements OnInit, OnDestroy { | |||
| this.reportForm.reset(); | |||
| this.reportForm.controls.solution.setValue($event.value); | |||
| this.reportForm.controls.programName.setValue(program); | |||
|
|
|||
| this.displayFilters['Resource'] = [$event.source.triggerValue] | |||
There was a problem hiding this comment.
check for undefined case also in all place
There was a problem hiding this comment.
Whenever the click event on a filter dropdown triggers only then this value will be assigned so there won't be a case of undefined source or triggerValue (as it'd be the cause of the event)
There was a problem hiding this comment.
if event is not there this will give a undefined issue please use the ? operator
There was a problem hiding this comment.
Sure will do @rajeevsathish
.../src/app/modules/program-dashboard/components/program-datasets/program-datasets.component.ts
Show resolved
Hide resolved
| @@ -273,7 +275,7 @@ export class DatasetsComponent implements OnInit, OnDestroy { | |||
| this.reportForm.reset(); | |||
| this.reportForm.controls.solution.setValue($event.value); | |||
| this.reportForm.controls.programName.setValue(program); | |||
|
|
|||
| this.displayFilters['Resource'] = [$event.source.triggerValue] | |||
There was a problem hiding this comment.
if event is not there this will give a undefined issue please use the ? operator
|
Kudos, SonarCloud Quality Gate passed! |
No description provided.