Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue SB-30516 chore: Updated to new sunbird video player & video.js package in package.json #8213

Merged

Conversation

Xitija
Copy link
Contributor

@Xitija Xitija commented Aug 5, 2022

@rajeevsathish
PR for this change is being done for the purpose of testing of the new Sunbird video player package .
It will be reqiured as QA will get a platform to perform the testing.
PR will be reverted when the testing is completed.

Just wanted to know when the PR will be merged where can we see the changes on
dev.sunbirded.org or staging.sunbirded.org ?

@coolbung @baljeetsingh @vinukumar-vs @HarishGangula

Copy link
Contributor

@rajeevsathish rajeevsathish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please send only the changes needed in the yarn.lock I see lot of unreleated changes in the lock file

@Xitija
Copy link
Contributor Author

Xitija commented Aug 5, 2022

please send only the changes needed in the yarn.lock I see lot of unreleated changes in the lock file

I have cross verified all the changes with and without my package changes.
The changes are more because I am updating the video.js package from 7.4.1 to 7.18.1.
When I ran yarn install without my package change no new data was added to the file, updating the package only led to the file changes. All changes are required .

@rajeevsathish Sir please check and merge the PR.

@sonarcloud
Copy link

sonarcloud bot commented Aug 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rajeevsathish rajeevsathish merged commit a800d64 into Sunbird-Ed:release-4.10.3 Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants