Issue #SB-23689 fix: DF>>Admin's ability to turn DF on/off on the UI #6602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajeevsathish
suggested changes
May 28, 2021
| @@ -54,6 +54,19 @@ | |||
| </div> | |||
| </div> | |||
| <div class="four wide column"> | |||
| <div *ngIf="showDiscussionForum === 'Yes'"> | |||
| <label>Enable discussions</label> | |||
There was a problem hiding this comment.
why is this hard coded not a label?
| if (this.batchUpdateForm.value.enableDiscussions === 'true') { | ||
| this.discussionService.createForum(this.createForumRequest).subscribe(resp => { | ||
| this.handleEnableDFChange('Yes'); | ||
| this.toasterService.success('Enabled discussion forum successfully'); |
There was a problem hiding this comment.
here also the label should be used like
this.toasterService.error(this.resourceService.messages.emsg.m0005);
| } | ||
| } | ||
|
|
||
| handleEnableDFChange(inputType) { |
There was a problem hiding this comment.
do we need a separate method?
|
Kudos, SonarCloud Quality Gate passed! |
rajeevsathish
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #SB-23689 fix: DF>>Admin's ability to turn DF on/off on the UI