Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #ED-4177 fix: Fixed the test cases #3602

Merged
merged 22 commits into from
May 3, 2024

Conversation

Ajoymaity
Copy link
Contributor

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

Please choose appropriate options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes in the below checkboxes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Ran Test A
  • Ran Test B

Test Configuration:

  • Node - 12.22.10
  • Java - 11.0.15.1
  • Ionic - 5.7.0
  • Cordova - 10.1.2
  • Gradle - 7.0.2

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@@ -557,6 +557,7 @@ export enum InteractSubtype {
APPLE = 'apple',
STATE = 'state',
COURSE_KEBAB_MENU_CLICKED = 'course-kebab-menu-clicked',
CATEGORY_CLICKED = '-clicked'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CATEGORY_CLICKED = '%-clicked'
and in the code replace the percentile with your value.

Copy link

sonarqubecloud bot commented May 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
15.0% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

@swayangjit swayangjit merged commit 1c0c45f into Sunbird-Ed:release-7.0.0 May 3, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants