Remove shapely from dependencies #119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
base geometries will only be used for plotting so they don't need complex geometry interaction methods like casting, cutting, merging, ...
anomam
force-pushed
the
remove_shapely_dep
branch
from
7b8a8de to
d76fb5a
Compare
anomam
force-pushed
the
remove_shapely_dep
branch
from
d76fb5a to
e6520f7
Compare
|
Hi, i'm starting to use pvfactors, is a really great tool, but i had a question. Is the program capable of discretizing the terrain? I mean, I know that it consider the "cut points" and the shadow and not shadow areas, but it can consider a certain zone where I can consider a bigger value of albedo? In other words, i want to quantify the impact of install a reflective surface on the front or under of the PV row, is this possible with pvfactors? What would you recommend me for this? I appreciate your help, regards! |
This was referenced Nov 20, 2021
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the implementation of vectorized calculations in pvfactors, the
shapelydependency has only been in use for plotting PV arrays, so there is really no need for it anymore, especially considering all the trouble it brings because of theGEOSdependency.The goal of this PR is to remove
shapely(and thereforeGEOS) as dependency forpvfactors.shapelyused to be at the core of the package though, so it will require substantial work to remove it cleanly and clean up the geometry part of the package because of the legacy code.