fix(opamp): Add the Default provider to the provider list in ConfigProviderSettings #1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnishtala-sumo
force-pushed
the
add-default-provider
branch
from
8b7ab0a to
d871922
Compare
echlebek
approved these changes
Jul 22, 2024
rnishtala-sumo
force-pushed
the
add-default-provider
branch
from
d871922 to
bb9ead2
Compare
…oviderSettings. When the Scheme for a config URI isn't specified, the DefaultScheme is set to the env, therefore this provider now needs to be included in the provider list.
rnishtala-sumo
force-pushed
the
add-default-provider
branch
from
bb9ead2 to
e314525
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the Default provider to the provider list in ConfigProviderSettings. When the Scheme for a config URI isn't specified, the DefaultScheme is set to the env, therefore this provider now needs to be included in the provider list.
Related to this upstream breaking change - open-telemetry/opentelemetry-collector#10435