-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumping up Serilog to 3.* #119
Conversation
@rnishtala-sumo Can this PR get some attention 🙏 - this library prevents upgrading of other Serilog packages. |
Yes we need this... |
We need this so that we can get trace and span ids in properly, see serilog/serilog-extensions-logging#227 |
Yes, we need this too! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
A new version has been released for this, apologies for the delay |
Serilog has been upgraded to version >=3.0.0. SumoLogic.Logging.Serilog only supports Serilog < 3.0.0. This dependency has now been set to use Serilog >=2.0.0 and <4.0.0.