Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping up Serilog to 3.* #119

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Bumping up Serilog to 3.* #119

merged 1 commit into from
Dec 13, 2023

Conversation

JoshGlue
Copy link
Contributor

Serilog has been upgraded to version >=3.0.0. SumoLogic.Logging.Serilog only supports Serilog < 3.0.0. This dependency has now been set to use Serilog >=2.0.0 and <4.0.0.

@wdolek
Copy link
Contributor

wdolek commented Dec 4, 2023

@rnishtala-sumo Can this PR get some attention 🙏 - this library prevents upgrading of other Serilog packages.

@stotlyakov
Copy link

Yes we need this...

@droyad
Copy link

droyad commented Dec 7, 2023

We need this so that we can get trace and span ids in properly, see serilog/serilog-extensions-logging#227

@clausndk
Copy link

Yes, we need this too!
@rnishtala-sumo, @wdolek, who can merge?

Copy link
Contributor

@rnishtala-sumo rnishtala-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rnishtala-sumo rnishtala-sumo merged commit 16130b7 into SumoLogic:main Dec 13, 2023
@rnishtala-sumo
Copy link
Contributor

rnishtala-sumo commented Dec 20, 2023

A new version has been released for this, apologies for the delay
https://github.com/SumoLogic/sumologic-net-appenders/releases/tag/1.0.1.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants