allow the ability to cleanup previously configured local sources #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases even if temporarily one may want to remove a source from being ingested into sumologic. In other cases it's cleaning up dead code for something that no longer generates logs in the environment. Signed-off-by: Ben Abrams <[email protected]>
majormoses
force-pushed
the
feature/source-action-remove
branch
from
605c3c6 to
f9b6583
Compare
|
Hi @majormoses, Thanks for the PR. LGTM, but please update
|
Signed-off-by: Ben Abrams <[email protected]>
sumo-drosiek
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General
Remove any versioning you did yourself if applicable
Update Changelog following the conventions laid out on Keep A Changelog with all new changes under
## [Unreleased]and using a### Added, Fixed, Changed, or Breaking Changesub-header.Update README with any necessary changes
RuboCop passes
Foodcritic passes
Existing tests pass
Purpose
In some cases even if temporarily one may want to remove a source from being ingested into sumologic. In other cases it's cleaning up dead code for something that no longer generates logs in the environment.
Known Compatibility Issues
None