k8sprocessor: add host.name and container.name fields #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmm-sumo
reviewed
Sep 30, 2020
| } | ||
|
|
||
| sort.Strings(names) | ||
| tags[conventions.AttributeContainerName] = strings.Join(names, ",") |
There was a problem hiding this comment.
We've been using ", " (with space) previously. But! Perhaps a better option would be to use native array structure for this if several values are present. OTLP model supports it
There was a problem hiding this comment.
How exactly would you like to serialize it? tags is a map[string]string. Something like fmt.Sprintf(names)?
There was a problem hiding this comment.
The intermediate layer (tags) might need some rethinking but eventually it might be stored as this: https://github.com/open-telemetry/opentelemetry-proto/blob/master/opentelemetry/proto/common/v1/common.proto#L36
pmm-sumo
reviewed
Sep 30, 2020
pmm-sumo
reviewed
Sep 30, 2020
pmm-sumo
approved these changes
Sep 30, 2020
sumo-drosiek
pushed a commit
that referenced
this pull request
Jun 1, 2022
In some circumstances, a log entry could be unsuccessfully parsed. It is intended that a failure can result in an entry being "sent" to the next operator, but when this happens, the parser should cease execution immediately. Prior to this change, this was not always the case, as some parsers would continue on and "send" the entry again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds option to tag data with
host.nameandcontainer.namefields.