Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't trigger gender, better handling of non-disclosed pronouns #875

Merged
merged 4 commits into from
Aug 12, 2024

Conversation

nonprofittechy
Copy link
Member

Fix #874

This PR updates the pronoun, pronoun_possessive, and pronoun_subjective methods in the al_general.py module to provide more robust handling of pronouns, including support for multiple pronouns and custom user-provided pronouns. Key changes include:

  • Enhanced Pronoun Flexibility: The methods now support the use of multiple pronouns (e.g., "he/they")
  • Parse custom pronouns in .pronouns as a DADict, not just in pronouns_self_described
  • Don't trigger gender or pronouns: if the pronouns or gender attributes are not defined or can't be parsed, fall back on either a user-provided default (like "the agent") or the person's full name

This may change behavior of some interviews that don't currently, explicitly, trigger a question about pronouns or gender.

Copy link

@samglover samglover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice update!

@nonprofittechy nonprofittechy merged commit 1853070 into main Aug 12, 2024
5 checks passed
@nonprofittechy nonprofittechy deleted the better-pronouns branch August 12, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants