Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pass 'bare' parameter unless it's an ALAddress #817

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

nonprofittechy
Copy link
Member

@nonprofittechy nonprofittechy commented Jan 19, 2024

Also don't pass show_impounded

Fix #816

Test YAML that only works after this change:

---
include:
  - assembly_line.yml
---
objects:
  - the_address: Address
---
id: your address
question: |
  What is your address?
subquestion: |
  Where do you live?
fields:
  - Street address: the_address.address
    address autocomplete: True
  - Unit: the_address.unit
    required: False
  - City: the_address.city
  - State: the_address.state
    code: |
      states_list()
    default: MA      
  - Zip: the_address.zip
    required: False
---
mandatory: True
code: |
  users.gather()
  users[0].address = the_address
  message(users[0].address_block())

@nonprofittechy nonprofittechy merged commit 151476f into main Jan 19, 2024
5 checks passed
@nonprofittechy nonprofittechy deleted the patch-assuming-addresses-are-aladdress branch January 19, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We incorrectly assume the address attribute is an ALAddress which breaks some interviews
1 participant