Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safer loading of YAML file with language names #766

Merged
merged 3 commits into from
Sep 23, 2023
Merged

Conversation

nonprofittechy
Copy link
Member

Corrected behavior of languages.py; it now will use a local languages.yml in the rare event that it exists, but correctly loads the package version of languages.yml in every other circumstances.

This was a breaking issue in the 209A but only visible on the test server so far.

Copy link
Contributor

@BryceStevenWilley BryceStevenWilley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't really understand this at first go because I think think it's not clear what "current" vs "local" refers to. I think "al" vs "local" is much clearer, so I made so suggestions that might help. Otherwise, looks good

docassemble/AssemblyLine/language.py Outdated Show resolved Hide resolved
docassemble/AssemblyLine/language.py Outdated Show resolved Hide resolved
@nonprofittechy nonprofittechy merged commit d77be96 into main Sep 23, 2023
@BryceStevenWilley BryceStevenWilley deleted the languages-fix branch September 25, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants