Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give more latitude about heading length #7

Merged
merged 3 commits into from
Apr 5, 2022
Merged

Give more latitude about heading length #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
77768f0
Fix #5; double wiggle-room for heading length
nonprofittechy Apr 5, 2022
7cef980
Keep original DA header lengths in pixels
BryceStevenWilley Apr 5, 2022
a6e22a7
Don't remove plumbum
BryceStevenWilley Apr 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion LICENSE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
The MIT License (MIT)

Copyright (c) 2021 Bryce Willey
Copyright (c) 2022 Bryce Willey

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand Down
2 changes: 1 addition & 1 deletion docassemble/ALLinter/linter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def headings_violations(headings):
# The widest DA headers get (in px), on a standard mobile device, and on a narrow mobile device
# (firefox, Pixel 2, and iPhone 5SE)
violations = []
stages = [540, 381, 290]
stages = [540 * 2, 381 * 2, 290 * 2]
for key, heading in headings.items():
heading_width = get_heading_width(heading)
longer_than_count = sum([heading_width > stage for stage in stages])
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def find_package_data(where='.', package='', exclude=standard_exclude, exclude_d
url='https://docassemble.org',
packages=find_packages(),
namespace_packages=['docassemble'],
install_requires=['Mako>=1.1.4', 'ruamel.yaml>=0.17.4', 'plumbum>=1.7.2', 'textstat>=0.7.0'],
install_requires=['Mako>=1.1.4', 'ruamel.yaml>=0.17.4', 'plumbum>=1.7.2', 'textstat>=0.7.0'],
zip_safe=False,
package_data=find_package_data(where='docassemble/ALLinter/', package='docassemble.ALLinter'),
)
Expand Down