Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the heading checker a little less sensitive #5

Closed
nonprofittechy opened this issue Apr 4, 2022 · 0 comments · Fixed by #7
Closed

Make the heading checker a little less sensitive #5

nonprofittechy opened this issue Apr 4, 2022 · 0 comments · Fixed by #7

Comments

@nonprofittechy
Copy link
Member

I think we might want to give people two lines before we warn them about over-long headings. It's a little noisy now.
nonprofittechy added a commit that referenced this issue Apr 5, 2022
@nonprofittechy
Fix #5; double wiggle-room for heading length
77768f0
@nonprofittechy nonprofittechy mentioned this issue Apr 5, 2022
Merged
BryceStevenWilley added a commit that referenced this issue Apr 5, 2022
@nonprofittechy @BryceStevenWilley
Give more latitude about heading length (#7)
54efa18 
* Fix #5; double wiggle-room for heading length

* Keep original DA header lengths in pixels

So it's clearer that the main numbers are still the above values in the comment (firefox, pixel 2, and 5SE), but that we're fudging them a bit.

* Don't remove plumbum

Co-authored-by: Bryce Willey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Give more latitude about heading length SuffolkLITLab/docassemble-ALLinter
1 participant
@nonprofittechy