Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore tables that don't exist #188

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Ignore tables that don't exist #188

merged 2 commits into from
Dec 19, 2024

Conversation

aryy-suffolk
Copy link
Contributor

@aryy-suffolk aryy-suffolk commented Dec 19, 2024

Attempts to resolve Tyler Code refresh issue.

We're changing it so when we try to delete data for a table that doesn't exist yet, it just skips it. It seems benign, but maybe we're missing some context.

@BryceStevenWilley no pressure to review, just so you're aware!

@aryy-suffolk aryy-suffolk merged commit 29f1ac0 into main Dec 19, 2024
3 checks passed
@aryy-suffolk aryy-suffolk deleted the fix-refresh branch December 19, 2024 17:47
@nonprofittechy
Copy link
Member

@BryceStevenWilley our assumption here is that it's safe to ignore a failure to delete data from a non-existing court location, as it just indicates that Tyler added a new jurisdiction we weren't aware of yet. But we didn't understand what this check was for before--so if you have time, please let us know if you think we're removing an important safety check

@BryceStevenWilley
Copy link
Collaborator

I think I would have only ignored deleting from an unknown table (where we don't have a query to run as opposed to a query running and failing somehow), but I think y'all are right as well, that deletes are unlikely to fail, and should be able to be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants