chore: parametrize user image docker repository #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
ThibaultFy
force-pushed
the
rename-substra-user-images
branch
from
c5b8100 to
ae2f666
Compare
|
/e2e --tests sdk,mnist |
|
End to end tests: ✔️ SUCCESS |
|
/e2e --tests substrafl, camelyon, doc |
|
End to end tests: ✔️ SUCCESS “Carpe diem. Seize the day, boys.” ― John Keating, Dead Poets Society |
ThibaultFy
changed the title
Signed-off-by: ThibaultFy <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
ThibaultFy
force-pushed
the
rename-substra-user-images
branch
from
da774b4 to
270c8af
Compare
Signed-off-by: ThibaultFy <[email protected]>
SdgJlbl
approved these changes
Apr 18, 2024
| @@ -16,6 +16,7 @@ | |||
| IMAGE_BUILD_CHECK_DELAY = settings.IMAGE_BUILD_CHECK_DELAY | |||
| REGISTRY = settings.REGISTRY | |||
| SUBTUPLE_TMP_DIR = settings.SUBTUPLE_TMP_DIR | |||
| USER_IMAGE_REPOSITORY = settings.USER_IMAGE_REPOSITORY | |||
There was a problem hiding this comment.
Unrelated comment but we really need to rename that module at some point 😅
Signed-off-by: ThibaultFy <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes FL-1541