Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch default S3 storage to MinIO #878

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Conversation

SdgJlbl
Copy link
Contributor

@SdgJlbl SdgJlbl commented Apr 4, 2024

fixes fl-1522

@SdgJlbl SdgJlbl requested a review from a team as a code owner April 4, 2024 12:26
Copy link

linear bot commented Apr 4, 2024

@SdgJlbl SdgJlbl force-pushed the chore/disable-localstack branch from da5fdaa to 5ff221f Compare April 4, 2024 12:32
Copy link
Member

@ThibaultFy ThibaultFy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@@ -2,6 +2,13 @@

<!-- towncrier release notes start -->

## [24.6.0] - 2024-04-04

### Changed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought you added towncrier on this changelog too ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but for now the CI check hasn't been changed yet, and there is a question on whether it's useful to use towncrier for manual updates given that we bump the version number at every change.

@SdgJlbl SdgJlbl force-pushed the chore/disable-localstack branch from 5ff221f to 4cdaf55 Compare April 4, 2024 14:15
@SdgJlbl
Copy link
Contributor Author

SdgJlbl commented Apr 4, 2024

/e2e --tests mnist

@Owlfred
Copy link

Owlfred commented Apr 4, 2024

End to end tests: ✔️ SUCCESS

Awesome! 🎉

@SdgJlbl SdgJlbl merged commit d4535ac into main Apr 4, 2024
10 checks passed
@SdgJlbl SdgJlbl deleted the chore/disable-localstack branch April 4, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants