Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check builder exists on create #847

Merged
merged 7 commits into from
Mar 6, 2024
Merged

fix: check builder exists on create #847

merged 7 commits into from
Mar 6, 2024

Conversation

guilhem-barthes
Copy link
Contributor

@guilhem-barthes guilhem-barthes commented Mar 4, 2024 •
edited
Loading

Description

Fixes FL-1438

How has this been tested?

Checklist

  • changelog was updated with notable changes
  • documentation was updated

@guilhem-barthes guilhem-barthes requested a review from a team as a code owner March 4, 2024 17:07
@github-actions github-actions bot added the api label Mar 4, 2024
@guilhem-barthes
Copy link
Contributor Author

/e2e --tests=sdk,substrafl,camelyon,mnist

@Owlfred
Copy link

Owlfred commented Mar 4, 2024 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

  • Camelyon / camelyon: ❌
  • Dispatch Jobs: ✔️
  • Documentation: ⏭️
  • Frontend: ⏭️
  • MNIST / mnist: ❌
  • SubstraFL / substrafl: ❌
  • SubstraSDK / sdk: ❌

That's a shame.

@linear Linear
Copy link

linear bot commented Mar 4, 2024

FL-1438 Add check if function.owner has a builder

@guilhem-barthes
Copy link
Contributor Author

/e2e --tests=sdk,substrafl,camelyon,mnist

@Owlfred
Copy link

Owlfred commented Mar 5, 2024 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

  • Camelyon / camelyon: ❌
  • Dispatch Jobs: ✔️
  • Documentation: ⏭️
  • Frontend: ⏭️
  • MNIST / mnist: ❌
  • SubstraFL / substrafl: ❌
  • SubstraSDK / sdk: ❌

Oh noes.

@guilhem-barthes
Copy link
Contributor Author

/e2e --tests=sdk,substrafl,camelyon,mnist

@Owlfred
Copy link

Owlfred commented Mar 5, 2024 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

I'm sorry.

@guilhem-barthes
Copy link
Contributor Author

/e2e --tests=mnist

@Owlfred
Copy link

Owlfred commented Mar 6, 2024 •
edited
Loading

End to end tests: ✔️ SUCCESS

Crushed it!

@guilhem-barthes guilhem-barthes force-pushed the fix/check-builder-exists-on-create branch from d9a9398 to ea14ed0 Compare March 6, 2024 13:14
@guilhem-barthes guilhem-barthes force-pushed the fix/check-builder-exists-on-create branch from ea14ed0 to 519539e Compare March 6, 2024 13:18
@guilhem-barthes
Copy link
Contributor Author

/e2e --tests=sdk,substrafl,camelyon,mnist

@Owlfred
Copy link

Owlfred commented Mar 6, 2024 •
edited
Loading

End to end tests: ❌ FAILURE

Jobs status:

  • Camelyon / camelyon: ❌
  • Dispatch Jobs: ✔️
  • Documentation: ⏭️
  • Frontend: ⏭️
  • MNIST / mnist: ❌
  • SubstraFL / substrafl: ❌
  • SubstraSDK / sdk: ❌

“Rien ne sert de courir ; il faut partir à point.” ― Jean de La Fontaine (Le Lièvre et la Tortue)

@guilhem-barthes
Copy link
Contributor Author

/e2e --tests=sdk,substrafl,camelyon,mnist

@Owlfred
Copy link

Owlfred commented Mar 6, 2024 •
edited
Loading

End to end tests: ✔️ SUCCESS

SdgJlbl
SdgJlbl approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@SdgJlbl SdgJlbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@guilhem-barthes guilhem-barthes merged commit 26e38bc into main Mar 6, 2024
10 checks passed
@guilhem-barthes guilhem-barthes deleted the fix/check-builder-exists-on-create branch March 6, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SdgJlbl SdgJlbl SdgJlbl approved these changes

@ThibaultFy ThibaultFy Awaiting requested review from ThibaultFy

Assignees
No one assigned
Labels
api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guilhem-barthes @Owlfred @SdgJlbl @ThibaultFy