Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove wait_for_image_built #819

Merged
merged 4 commits into from
Feb 13, 2024

Conversation

guilhem-barthes
Copy link
Contributor

@guilhem-barthes guilhem-barthes commented Feb 7, 2024

Companion PR

Description

Now that the orchestrator decides when to set the status TODO for the task only when needed to be executed, we can remove the logic to wait_for_image_built in the backend

Fixes FL-1204

How has this been tested?

CI in the companion PR

Checklist

  • changelog was updated with notable changes
  • documentation was updated

Copy link

linear bot commented Feb 8, 2024

@guilhem-barthes guilhem-barthes force-pushed the feat/update-compute-task-workflow branch 2 times, most recently from b8877ef to 39345cd Compare February 8, 2024 10:42
@guilhem-barthes guilhem-barthes marked this pull request as ready for review February 8, 2024 11:39
@guilhem-barthes guilhem-barthes requested a review from a team as a code owner February 8, 2024 11:39
Copy link
Contributor

@SdgJlbl SdgJlbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@guilhem-barthes guilhem-barthes force-pushed the feat/update-compute-task-workflow branch from 39345cd to 019d7ca Compare February 12, 2024 13:29
@guilhem-barthes guilhem-barthes force-pushed the feat/update-compute-task-workflow branch from 019d7ca to 1bcb9b9 Compare February 12, 2024 15:21
guilhem-barthes added a commit to Substra/orchestrator that referenced this pull request Feb 13, 2024
## Companion PR

- Substra/substra-backend#819

## Description

Add function status in the compute task workflow. Now tasks are are
going to have status `TODO` after the function is built.

Note: The status TODO will be changed and more statuses will be added in
another PR.

Fixes FL-1204

## How has this been tested?

CI 👇 

## Checklist

- [x] [changelog](../CHANGELOG.md) was updated with notable changes
- [ ] documentation was updated

---------

Signed-off-by: Guilhem Barthés <[email protected]>
@guilhem-barthes guilhem-barthes merged commit 9906d7d into main Feb 13, 2024
6 checks passed
@guilhem-barthes guilhem-barthes deleted the feat/update-compute-task-workflow branch February 13, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants