chore: remove metric from performance #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ThibaultFy <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
SdgJlbl
reviewed
May 11, 2023
| @@ -376,5 +358,5 @@ def test_n_plus_one_queries_performance_list(authenticated_client, create_comput | |||
| with utils.CaptureQueriesContext(connection) as query: | |||
| print(authenticated_client.get(url)) | |||
| query_task_with_perf = len(query.captured_queries) | |||
| assert query_task_with_perf < 12 | |||
| assert query_task_with_perf - query_tasks_empty < 4 | |||
| assert query_task_with_perf < 11 | |||
SdgJlbl
reviewed
May 11, 2023
| @@ -68,6 +68,7 @@ ASCENDING: SortOrder.ValueType # 1 | |||
| DESCENDING: SortOrder.ValueType # 2 | |||
| global___SortOrder = SortOrder | |||
|
|
|||
| @typing_extensions.final | |||
There was a problem hiding this comment.
Out of curiosity, what is this line doing?
There was a problem hiding this comment.
There was a problem hiding this comment.
It was auto generated, I didn't have your curiosity ahah. Thanks for pointing that out, really interesting indeed !
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove metric from the performance data model
Companion PR