fix: make BuildError serialisable by Celery in case of retry #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SdgJlbl <[email protected]>
|
/e2e |
|
End to end tests: ✔️ SUCCESS |
|
/e2e |
|
/e2e |
|
End to end tests: ✔️ SUCCESS Crushed it! |
Signed-off-by: SdgJlbl <[email protected]>
Signed-off-by: SdgJlbl <[email protected]>
Signed-off-by: SdgJlbl <[email protected]>
Signed-off-by: SdgJlbl <[email protected]>
SdgJlbl
force-pushed
the
fix/patch-celery-retry-error-regression
branch
from
73d83c7 to
51fabaf
Compare
|
/e2e |
|
End to end tests: ✔️ SUCCESS Congratulations! |
oleobal
reviewed
Apr 28, 2023
| logs = get_pod_logs(k8s_client, pod_name, KANIKO_CONTAINER_NAME, ignore_pod_not_found=True) | ||
| delete_pod(k8s_client, pod_name) | ||
| for line in (logs or "").split("\n"): | ||
| logger.info(line, pod_name=pod_name) |
There was a problem hiding this comment.
Do we want to log this line by line, rather than as a single JSON line?
(I know the backend logs are supposed to be JSONified but IDK about this)
There was a problem hiding this comment.
Well spotted, that might be the very reason why we have so many lines of log coming from Kaniko.
I'd be in favour to try adding all in the same log, what do you think @guilhem-barthes ?
oleobal
approved these changes
Apr 28, 2023
Signed-off-by: SdgJlbl <[email protected]>
guilhem-barthes
approved these changes
May 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Workaround for this Celery bug
How has this been tested?
Checklist