Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: increase max attempts for kaniko and return logs instead of raising #637

Merged
merged 2 commits into from
Apr 20, 2023
Merged

fix: increase max attempts for kaniko and return logs instead of raising #637

merged 2 commits into from
Apr 20, 2023

Conversation

SdgJlbl
Copy link
Contributor

@SdgJlbl SdgJlbl commented Apr 20, 2023 •
edited
Loading

Description

This PR does two things to patch instable behaviours in Kaniko observed lately.

  • Increase the number of attempts, hence the time we wait, in the watch_pod function.
  • Catch exception raised by the get_pod_logs, so that it does not crash the worker BEFORE deleting the kaniko pod it created.

How has this been tested?

Not yet, card created to add unit test as follow-up.

Checklist

  • changelog was updated with notable changes
  • documentation was updated

@SdgJlbl SdgJlbl requested a review from a team as a code owner April 20, 2023 15:32
guilhem-barthes
guilhem-barthes approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@guilhem-barthes guilhem-barthes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your work 🙏

@SdgJlbl
fix: add changelog
948f9c2 
Signed-off-by: SdgJlbl <[email protected]>
@SdgJlbl SdgJlbl merged commit a7e3ed6 into main Apr 20, 2023
@SdgJlbl SdgJlbl deleted the fix/kaniko-causes-worker-crashloopbackoff branch April 20, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guilhem-barthes guilhem-barthes guilhem-barthes approved these changes

Assignees
No one assigned
Labels
compute-engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SdgJlbl @guilhem-barthes