Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: test due to deprecation #612

Merged
merged 4 commits into from
Mar 9, 2023
Merged

fix: test due to deprecation #612

merged 4 commits into from
Mar 9, 2023

Conversation

guilhem-barthes
Copy link
Contributor

Description

Add new deprecation to remove error in CI due to new deprecation warning set in setuptools version 67.5.0

How has this been tested?

Local CI

Checklist

  • changelog was updated with notable changes
  • documentation was updated

@guilhem-barthes guilhem-barthes marked this pull request as ready for review March 9, 2023 09:54
@guilhem-barthes guilhem-barthes requested a review from a team as a code owner March 9, 2023 09:54
SdgJlbl
SdgJlbl approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@SdgJlbl SdgJlbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes :)
Do we have a way of setting a reminder to check if this filter is still needed later down the line?

@oleobal
Copy link
Contributor

oleobal commented Mar 9, 2023

Do we have a way of setting a reminder to check if this filter is still needed later down the line?

Good idea

@guilhem-barthes guilhem-barthes merged commit bb1f1f1 into main Mar 9, 2023
@guilhem-barthes guilhem-barthes deleted the fix/test-due-to-deprecation branch March 9, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleobal oleobal oleobal approved these changes

@SdgJlbl SdgJlbl SdgJlbl approved these changes

@Milouu Milouu Awaiting requested review from Milouu Milouu is a code owner automatically assigned from Substra/code-owners

@ThibaultFy ThibaultFy Awaiting requested review from ThibaultFy ThibaultFy is a code owner automatically assigned from Substra/code-owners

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guilhem-barthes @oleobal @SdgJlbl