fix: Add same expiration date that header_payload to signature cookie #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Milouu
requested review from
AlexandrePicosson,
AurelienGasser,
cboillet-dev,
Kelvin-M,
mblottiere,
samlesu,
sergebouchut2,
ThibaultFy,
oleobal and
guilhem-barthes
as code owners
Milouu
force-pushed
the
fix/signature-cookie-exp
branch
from
a3a79ca to
70f2623
Compare
Milouu
changed the title
Milouu
changed the title
Signed-off-by: Milouu <[email protected]>
Milouu
force-pushed
the
fix/signature-cookie-exp
branch
from
70f2623 to
ded607d
Compare
|
I am not sure to understand why having different dates results in a bug but I think this was defined as is on purpose. See https://github.com/Substra/substra-backend/blob/main/docs/authentication.md#jwt-cookie |
Signed-off-by: Milouu <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
ThibaultFy
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Access token in Substra is secured by separating the cookie in 2 cookies: header_payload and signature. The header_payload cookie has a 24h expiration date but the signature had none. Because of this once the header_payload expired there was a bug as the signature was still existing which blocked the creation of a new pair of cookies (be it from the refresh token or entering credentials again), which led to the user having to delete the signature cookie manually to resolve the issue.
This fix only give the same expiration date to the signature cookie so that it disappears at the same time as header_payload. If the user still has a refresh token (1 week expiration date), a new header_payload-signature pair will be fetched automatically, otherwise credentials have to be entered anew.
How has this been tested?
Checklist