Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix items unequipping when rejoining the server #2196

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Fix items unequipping when rejoining the server #2196

wants to merge 11 commits into from

Conversation

SpaceMonkeyy86
Copy link
Contributor

@SpaceMonkeyy86 SpaceMonkeyy86 commented Nov 12, 2024 •
edited
Loading

We may want to redo this implementation later if the server needs to handle more metadata updates itself. For now, this will work. This fix will help with testing so I think it's good if we merge it how it is.
Resolves #2186

@dartasen
Copy link
Member

Works fine IG

tornac1234
tornac1234 requested changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@tornac1234 tornac1234 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good fix, for which I'd like a lil improvement already (even though we could have as well "cleaned" this later on, I think the PR is is not too big so we can do the change right now)

NitroxClient/GameLogic/InitialSync/EquippedItemInitialSyncProcessor.cs Outdated Show resolved Hide resolved
NitroxServer/Communication/Packets/Processors/EntityMetadataUpdateProcessor.cs Outdated Show resolved Hide resolved
NitroxServer/Communication/Packets/Processors/EntityMetadataUpdateProcessor.cs Outdated Show resolved Hide resolved
NitroxServer/Communication/Packets/Processors/EntityMetadataUpdateProcessor.cs Outdated Show resolved Hide resolved
Jannify
Jannify requested changes Dec 15, 2024
View reviewed changes
Copy link
Member

@Jannify Jannify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my investigation the following files can be removed with the changes:

  • NitroxClient/GameLogic/Helper/SerializationHelper.cs
  • NitroxPatcher/Patches/Dynamic/UniqueIdentifier_Id_Getter_Patch.cs

NitroxModel/Packets/InitialPlayerSync.cs Show resolved Hide resolved
NitroxServer/Communication/Packets/Processors/EntityMetadataUpdateProcessor.cs Outdated Show resolved Hide resolved
@SpaceMonkeyy86
Copy link
Contributor Author

@Jannify Changes have been addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jannify Jannify Jannify requested changes

@Coding-Hen Coding-Hen Coding-Hen left review comments

@tornac1234 tornac1234 Awaiting requested review from tornac1234

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Equipped items are unequipped when rejoining the server
5 participants
@SpaceMonkeyy86 @dartasen @Coding-Hen @Jannify @tornac1234