Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify teleport to move vehicle #2111

Merged
merged 3 commits into from
Feb 9, 2025
Merged

Modify teleport to move vehicle #2111

merged 3 commits into from
Feb 9, 2025

Conversation

MistaOmega
Copy link
Contributor

Attempting to modify the vehicle teleport behaviour.

Correctly updates player pos with player in seamoth / prawn

@tornac1234 tornac1234 added Area: vehicles Related to vehicles (seamoth, cyclops, prawn) Type: enhancement labels Jan 21, 2024
@MistaOmega MistaOmega requested a review from Jannify May 24, 2024 15:00
@Measurity Measurity added this to the 1.8 milestone Aug 9, 2024
Jannify
Jannify approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@Jannify Jannify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the one comment LGTM CW

tornac1234
tornac1234 requested changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@tornac1234 tornac1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is lacking a feature which is allowing the warpforward command to also work with vehicles as well

Also please apply a rebase to this branch so you can test it with the latest movement PR merged

@MistaOmega MistaOmega force-pushed the Modify-Teleport-To-Move-Vehicle branch from 79b87b0 to 495287f Compare November 22, 2024 18:22
Jannify
Jannify approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@Jannify Jannify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM CW

@Jannify
Copy link
Member

Jannify commented Jan 5, 2025

Needs rebase and review from @tornac1234

@tornac1234 tornac1234 force-pushed the Modify-Teleport-To-Move-Vehicle branch from efd6bb3 to b4924b9 Compare January 12, 2025 12:31
@tornac1234
Copy link
Collaborator

Squashed for simplicity, rebased and applied some modifications.

@Gauvino
Copy link

Gauvino commented Jan 13, 2025

Just tested this PR and no longer problem with the seamoth

Gauvino
Gauvino approved these changes Jan 13, 2025
View reviewed changes
Copy link

@Gauvino Gauvino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From ingame testing it's good

@tornac1234 tornac1234 force-pushed the Modify-Teleport-To-Move-Vehicle branch from b4924b9 to 828e323 Compare February 8, 2025 21:20
@tornac1234 tornac1234 requested a review from Jannify February 8, 2025 21:20
@tornac1234 tornac1234 merged commit 262b219 into SubnauticaNitrox:master Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Measurity Measurity Measurity left review comments

@Coding-Hen Coding-Hen Coding-Hen approved these changes

@dartasen dartasen dartasen approved these changes

@Jannify Jannify Jannify approved these changes

@tornac1234 tornac1234 tornac1234 approved these changes

@Gauvino Gauvino Gauvino approved these changes

Assignees
No one assigned
Labels
Area: vehicles Related to vehicles (seamoth, cyclops, prawn) Type: enhancement
Projects
None yet
Milestone
1.8
Development

Successfully merging this pull request may close these issues.
7 participants
@MistaOmega @Jannify @tornac1234 @Gauvino @Measurity @Coding-Hen @dartasen