Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read Project Settings #252

Closed
wants to merge 5 commits into from

Conversation

mkrs
Copy link

@mkrs mkrs commented Aug 14, 2014

I extended the get_settings function to also consider project settings of the active window.
All default settings (except the 'extra_tag_paths') are supported.
I also updated the README to reflect these changes.

@stephenfin
Copy link
Contributor

I'd also prefer these commits squashed into two commits - one for implementation and one for docs - if at all possible. Do this and I'm happy to merge.

@mkrs
Copy link
Author

mkrs commented Aug 18, 2014

Sure. I am happy to correct this. Do you have a pylintrc for me to use, or should I just use PEP8? Also do you have a preference on how to merge/overwrite the extra_tag_paths? Then I would also add this.

@stephenfin
Copy link
Contributor

Any news on this?

@mkrs
Copy link
Author

mkrs commented Sep 7, 2014

I fixed the things you pointed out. Do you have a way to merge/overwrite the extra_tag_paths option? And I also don't exactly know how to squash these commits into 2 commits, do you have a hint how I can accomplish that?

@stephenfin
Copy link
Contributor

I fixed the things you pointed out.

Good stuff.

Do you have a way to merge/overwrite the extra_tag_paths option?

What is special about this option? I can have a look myself, but it'll be a few days (personally I wouldn't worry about it for now - it can also go in a separate commit).

And I also don't exactly know how to squash these commits into 2 commits, do you have a hint how I can accomplish that?

You'll want to look at the git rebase -i command. There's a very good guide here.

@mkrs
Copy link
Author

mkrs commented Sep 8, 2014

Here is the default setting:

// Paths to additional tag files to include in tag search. This is a list
// of items in the form [["language", "platform"], "path"]
"extra_tag_paths": [[["source.python", "windows"], "C:\Python27\Lib\tags"]]

I am wondering how to merge or should I just overwrite the setting?

@stephenfin
Copy link
Contributor

Here is the default setting:

// Paths to additional tag files to include in tag search. This is a list
// of items in the form [["language", "platform"], "path"]
"extra_tag_paths": [[["source.python", "windows"],
"C:\Python27\Lib\tags"]]

I am wondering how to merge or should I just overwrite the setting?

I would just overwrite it personally - don't see any point in keeping it. Do be sure to keep the same format though obviously.

@stephenfin
Copy link
Contributor

Any further updates? This is a useful addition that I would like to merge, if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants