-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read Project Settings #252
Conversation
I'd also prefer these commits squashed into two commits - one for implementation and one for docs - if at all possible. Do this and I'm happy to merge. |
Sure. I am happy to correct this. Do you have a pylintrc for me to use, or should I just use PEP8? Also do you have a preference on how to merge/overwrite the extra_tag_paths? Then I would also add this. |
Any news on this? |
I fixed the things you pointed out. Do you have a way to merge/overwrite the extra_tag_paths option? And I also don't exactly know how to squash these commits into 2 commits, do you have a hint how I can accomplish that? |
Good stuff.
What is special about this option? I can have a look myself, but it'll be a few days (personally I wouldn't worry about it for now - it can also go in a separate commit).
You'll want to look at the |
Here is the default setting: // Paths to additional tag files to include in tag search. This is a list I am wondering how to merge or should I just overwrite the setting? |
I would just overwrite it personally - don't see any point in keeping it. Do be sure to keep the same format though obviously. |
Any further updates? This is a useful addition that I would like to merge, if possible. |
84a89c7
to
ec92aac
Compare
I extended the get_settings function to also consider project settings of the active window.
All default settings (except the 'extra_tag_paths') are supported.
I also updated the README to reflect these changes.