-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added function to find project root #66
added function to find project root #66
Conversation
Hm. I don't see that directly in their docs. What's the passage I should read? Btw there is no But you also checked that the working dir follows and is correct after your patch? A typical pylint complication is that we provide files (paths) to it but it really wants the dotted |
@kaste the var I just added a |
feeling dumb.... I had a settings override for the pylint working_dir It is using my root pyproject now. Thanks :) |
Fixes #1883 Fixes SublimeLinter/SublimeLinter-pylint#57 Closes SublimeLinter/SublimeLinter-mypy#53 Closes SublimeLinter/SublimeLinter-pylint#66 Ref #1890 - Detect the typical name "venv" as a virtual environment candidate - Search for typical files/names and set `project_root` accordingly. This will in turn affect the `working_dir` we use unless overridden by the user.
Fixes #1883 Fixes SublimeLinter/SublimeLinter-pylint#57 Closes SublimeLinter/SublimeLinter-mypy#53 Closes SublimeLinter/SublimeLinter-pylint#66 Ref #1890 - Detect the typical name "venv" as a virtual environment candidate - Search for typical files/names and set `project_root` accordingly. This will in turn affect the `working_dir` we use unless overridden by the user.
This is intended to address #57. It correctly finds the project root, but somehow pylint is still not using the settings from
pyproject.toml
....@kaste do you have any ideas what is up?
Normally I have to add a init.py file to my project root, but in this case where we are linting one file, the pylint docs say this "should" work: https://pylint.pycqa.org/en/latest/user_guide/usage/run.html