Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log plugin errors to the console #25

Merged
merged 3 commits into from
Mar 6, 2018
Merged

Log plugin errors to the console #25

merged 3 commits into from
Mar 6, 2018

Conversation

thelfensdrfer
Copy link
Contributor

@thelfensdrfer thelfensdrfer commented Feb 1, 2018

Without this added line, errors raised by the plugin were not displayed in the sublime console.

@kaste
Copy link
Contributor

kaste commented Mar 3, 2018

What's the intent here, really. To provide a description isn't too much. Why shouldn't we listen to STDERR

@thelfensdrfer
Copy link
Contributor Author

Sorry about that, added an description.

@kaste
Copy link
Contributor

kaste commented Mar 5, 2018

Ah, and that works? If we don't claim STDERR Sublime wires it up for us.

Most plugins actually capture the errors (hence this is the default) and then don't know ... log them LOL

@thelfensdrfer
Copy link
Contributor Author

Yeah I don't know either. All I know is that this line fixed it for me ;)

@kaste
Copy link
Contributor

kaste commented Mar 5, 2018

Yeah, cool. I'll take it without the merge conflicts. 😛

@kaste kaste merged commit af586e5 into SublimeLinter:master Mar 6, 2018
@kaste
Copy link
Contributor

kaste commented Mar 6, 2018

Okay, 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants