Fixed #88 and removed unnecessary preference #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes some crashes caused by the fact that multiple languages were concatenated as strings (eg "eng+ita") and sent to functions that treated the string as a single language. These functions now take a `Set<Language>`.
The first commit tried to download null language the first time the app was run, and language download dialogs appeared again and again. Also clarified some method names and inserted `@NonNull` where needed.
Languages are now handled correctly for shared images.
There is no reason to be restricted to one language, so the option has been removed to simplify the preference code.
|
After selecting multiple languages(other than English) Language data is not downloading (no dialog for download selected language). Neither showing selected language on home screen. |
Merged
|
Looks like good news. Looking forward to seeing the new build on F-Droid. |
|
@SubhamTyagi any updates on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some crashes caused by the fact that multiple languages were concatenated as strings (eg "eng+ita") and sent to functions that treated the string as a single language.
These functions now take a
Set<Language>.The
ListPreferencefor a single language has also been removed, since you can just pick a single one from the multi-select one.