Nullsafety #548
Nullsafety #548
Conversation
|
I will go over this fully some time if you want. I certianly see some cases where I think we should use less |
|
Yes, please take a look and add commits if you feel necessary that would be great!. Imo this should be merged before anything else to prevent more merge conflicts, since you can't just run |
…into misc/nullsafety � Conflicts: � lib/src/replaced_element.dart
|
@erickok I've fixed all the merge conflicts. I think this is good to go This was indeed an issue and I fixed it with the most recent commit. |
|
@tneotia sounds like you can update the |
|
Yes @jlubeck but please allow is to do some proper testing. I know we all want a nullability-supporting flutter_html but this is a big job and we also don't want to have to release a dozen patches later. |
For sure! Sorry if my comment was disrespectful, wasn't aimed at rushing anything. Just super excited to get null safety flutter_html. Sorry again! |
|
@jlubeck done. Edit: it you'd like please test this as well. You use the package for Web extensively and as a result I think you can provide another perspective when testing. @erickok please do whatever testing is necessary, this really needs to squash all the existing bugs and not create any new regressions. Chewie audio still works great:
|
|
I am going to merge this and release a preview version. |
|
please public a new version for iframe video, I'm waiting for that. @erickok |
|
@roskimlong I'm not sure what you mean with iframe video? |
|
I tried to added iframe YouTube video not work but for link src beside YouTube is worked well |
Youtube iframe should work as I have used it in my app. Can you give us an example of a URL that doesn't work, preferably creating a new issue? Thanks. |
|
@roskimlong see #513 for some tips. But please make a new issue, with example code. |
|
@erickok i want to tried first before I create new issue brother ❤️❤️ I tried to fix as I can and then I will add new issues brother |
Refactor to nullsafety. Taking this in stages, so I've marked it as a draft. If you'd like, you can look over what I've done so far and let me know if anything should be changed.
Update:
Migration complete - I've tested with as many HTML edge cases I can think of and it is still working great. I used the
!operator more than I anticipated, but I don't know if that is an issue, per se.Fixes #511, fixes #468, fixes #399, fixes #568, fixes #274 (as far as I can tell)