fix: Fix bug in CheckboxSelectAllController preventing connect() from…

… adding event listeners
Sub-Xaero · Feb 9, 2021 · db577a9 · db577a9
1 parent 31336f9
commit db577a9
Show file tree

Hide file tree

Showing 14 changed files with 16 additions and 16 deletions.
diff --git a/dist/checkbox_select_all_controller.d.ts b/dist/checkbox_select_all_controller.d.ts
@@ -1,7 +1,7 @@
 import { BaseController } from './base_controller';
 export declare class CheckboxSelectAllController extends BaseController {
     static targets: string[];
-    readonly hasCheckboxAllTarget: boolean;
+    readonly hasSelectAllTarget: boolean;
     readonly selectAllTarget: HTMLInputElement;
     readonly checkboxTargets: HTMLInputElement[];
     private get checked();

diff --git a/dist/checkbox_select_all_controller.d.ts.map b/dist/checkbox_select_all_controller.d.ts.map
diff --git a/dist/index.d.ts b/dist/index.d.ts
@@ -14,8 +14,8 @@ export { EmptyDomController } from "./empty_dom_controller";
 export { EnableInputsController } from "./enable_inputs_controller";
 export { FallbackImageController } from "./fallback_image_controller";
 export { FormSaveController } from "./form_save_controller";
-export { LightboxImageController } from "./lightbox_image_controller";
 export { LazyBlockController } from "./lazy_block_controller";
+export { LightboxImageController } from "./lightbox_image_controller";
 export { LimitedSelectionCheckboxesController } from "./limited_selection_checkboxes_controller";
 export { NestedFormController } from "./nested_form_controller";
 export { PasswordConfirmController } from "./password_confirm_controller";

diff --git a/dist/index.d.ts.map b/dist/index.d.ts.map
diff --git a/dist/stimulus-library.js b/dist/stimulus-library.js
diff --git a/dist/stimulus-library.js.map b/dist/stimulus-library.js.map
diff --git a/dist/stimulus-library.modern.js b/dist/stimulus-library.modern.js
diff --git a/dist/stimulus-library.modern.js.map b/dist/stimulus-library.modern.js.map
diff --git a/dist/stimulus-library.module.js b/dist/stimulus-library.module.js
diff --git a/dist/stimulus-library.module.js.map b/dist/stimulus-library.module.js.map
diff --git a/dist/stimulus-library.umd.js b/dist/stimulus-library.umd.js
diff --git a/dist/stimulus-library.umd.js.map b/dist/stimulus-library.umd.js.map
diff --git a/src/checkbox_select_all_controller.ts b/src/checkbox_select_all_controller.ts
@@ -3,7 +3,7 @@ import {BaseController} from './base_controller';
 export class CheckboxSelectAllController extends BaseController {
   static targets = ['selectAll', 'checkbox'];
 
-  declare readonly hasCheckboxAllTarget: boolean;
+  declare readonly hasSelectAllTarget: boolean;
   declare readonly selectAllTarget: HTMLInputElement;
   declare readonly checkboxTargets: HTMLInputElement[];
 
@@ -22,7 +22,7 @@ export class CheckboxSelectAllController extends BaseController {
 
   connect() {
     requestAnimationFrame(() => {
-      if (!this.hasCheckboxAllTarget) {
+      if (!this.hasSelectAllTarget) {
         return;
       }
 
@@ -33,7 +33,7 @@ export class CheckboxSelectAllController extends BaseController {
   }
 
   disconnect() {
-    if (!this.hasCheckboxAllTarget) {
+    if (!this.hasSelectAllTarget) {
       return;
     }
 

diff --git a/src/index.ts b/src/index.ts
@@ -14,8 +14,8 @@ export {EmptyDomController} from "./empty_dom_controller";
 export {EnableInputsController} from "./enable_inputs_controller";
 export {FallbackImageController} from "./fallback_image_controller";
 export {FormSaveController} from "./form_save_controller";
-export {LightboxImageController} from "./lightbox_image_controller";
 export {LazyBlockController} from "./lazy_block_controller";
+export {LightboxImageController} from "./lightbox_image_controller";
 export {LimitedSelectionCheckboxesController} from "./limited_selection_checkboxes_controller";
 export {NestedFormController} from "./nested_form_controller";
 export {PasswordConfirmController} from "./password_confirm_controller";