Filter station without label (eclipse-set#1268)

SuB-PlanPro · Jan 21, 2025 · 3110dc8 · 3110dc8
1 parent 75bb263
commit 3110dc8
Showing 1 changed file with 21 additions and 22 deletions.
diff --git a/web/siteplan/src/feature/StationFeature.ts b/web/siteplan/src/feature/StationFeature.ts
@@ -31,7 +31,8 @@ export default class StationFeature extends LageplanFeature<Station> {
   }
 
   getFeatures (model: SiteplanState): Feature<Geometry>[] {
-    return this.getObjectsModel(model).map(element => this.createStationFeature(element))
+    return this.getObjectsModel(model).filter(element => element.label?.text)
+      .map(element => this.createStationFeature(element))
   }
 
   private createStationFeature (station: Station): Feature<Geometry> {
@@ -51,30 +52,28 @@ export default class StationFeature extends LageplanFeature<Station> {
       new Point(position),
       station.label?.text
     )
-    if (station.label?.text) {
-      feature.setStyle((_, resolution) => {
-        const baseResolution = this.map.getView().getResolutionForZoom(this.svgService.getBaseZoomLevel())
-        const scale = baseResolution / resolution
-        let textRotation = avgRotation
-        if (isLabelFlipRequired(textRotation - 90, this.map)) {
-          textRotation += 180
-        }
-
-        return new Style({
-          text: new Text({
-            text: 'Bstg ' + station.label.text,
-            scale: scale * 3,
-            rotateWithView: true,
-            rotation: textRotation * Math.PI / 180,
-            textAlign: 'center',
-            fill: new Fill({
-              color: getLabelColor(station) ?? 'black'
-            })
+    feature.setStyle((_, resolution) => {
+      const baseResolution = this.map.getView().getResolutionForZoom(this.svgService.getBaseZoomLevel())
+      const scale = baseResolution / resolution
+      let textRotation = avgRotation
+      if (isLabelFlipRequired(textRotation - 90, this.map)) {
+        textRotation += 180
+      }
+
+      return new Style({
+        text: new Text({
+          text: 'Bstg ' + station.label?.text,
+          scale: scale * 3,
+          rotateWithView: true,
+          rotation: textRotation * Math.PI / 180,
+          textAlign: 'center',
+          fill: new Fill({
+            color: getLabelColor(station) ?? 'black'
           })
         })
       })
-    }
-    
+    })
+
     return feature
   }