Handling complex click events on Shelly1, Shelly2.5, Shelly dimmer and Shelly dimmer2 with fw 1.8.x and above #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting you got it to work, but I don't understand what you trying to do. For example, what is LSTART meaning? |
|
This is the time diagram of events: |
|
I have done some testing with this version and it is looking good. Adding the info regarding the click_events as I see them.
This can be combined further as shown in the post above. I see some info from Shelly on this here -> http://shelly-api-docs.shelly.cloud#shelly-i3-input-events |
|
This is nice! I dont understand why this feature is not in the Shelly 1 & 2.5 microcode directly. So useful! |
g-kiss
changed the title
|
@hakana : is there any estimation date when it will be merged to the master? |
g-kiss
changed the title
|
@hakana Please add this to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR needs the (StyraHem/ShellyForHASS#438) PR too. The description see there.