Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 2024 #5

Merged
merged 5 commits into from
Jan 12, 2024
Merged

Update to 2024 #5

merged 5 commits into from
Jan 12, 2024

Conversation

BenG49
Copy link
Contributor

@BenG49 BenG49 commented Jan 12, 2024

No description provided.

@BenG49 BenG49 requested a review from anivanchen January 12, 2024 02:27
Copy link
Member

@anivanchen anivanchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this builds and simulates, I don't see any glaring issues.

import com.stuypulse.robot.util.SwerveDriveFollowTrajectory;

public class Mobility extends SequentialCommandGroup {
private static final PathConstraints CONSTRAINTS = new PathConstraints(2, 2);
private static final PathConstraints CONSTRAINTS = new PathConstraints(2, 2, 2, 2);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove since defined through GUI.

import com.stuypulse.robot.util.SwerveDriveFollowTrajectory;

public class MobilityBump extends SequentialCommandGroup {
private static final PathConstraints CONSTRAINTS = new PathConstraints(2, 2);
private static final PathConstraints CONSTRAINTS = new PathConstraints(2, 2, 2, 2);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove since defined in GUI.

import com.stuypulse.robot.util.SwerveDriveFollowTrajectory;

public class DriveAndTurnBump extends SequentialCommandGroup {
private static final PathConstraints CONSTRAINTS = new PathConstraints(2, 2);
private static final PathConstraints CONSTRAINTS = new PathConstraints(2, 2, 2, 2);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove since defined through GUI.

@BenG49 BenG49 merged commit 5d8e000 into main Jan 12, 2024
1 check passed
@BenG49 BenG49 deleted the se/migrate-2024 branch January 12, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants