Add support of Array in JSZip#load. #252
Merged
+80
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Stuk#250 case, we don't have fancy Uint8Array but we have a unsupported binary format. An array of bytes (numbers between 0 and 255) is the lowest common denominator. A binary string would awkward to build here and building it reliably can be tricky (without filling the stack or taking too much time/memory). This commit adds the missing `arrayReader` needed here.
Merged
Stuk
added a commit
that referenced
this pull request
Mar 9, 2016
Add support of Array in JSZip#load.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #250 case, we don't have fancy Uint8Array but we have an unsupported
binary format. An array of bytes (numbers between 0 and 255) is the
lowest common denominator. A binary string would awkward to build here
and building it reliably can be tricky (without filling the stack or
taking too much time/memory).
This commit adds the missing
arrayReaderneeded here.