Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.2.0 #106

Merged
merged 2 commits into from
Feb 26, 2014
Merged

Release v2.2.0 #106

merged 2 commits into from
Feb 26, 2014

Conversation

dduponchel
Copy link
Collaborator

Changes from v2.1.1 :

  • make the new operator optional before the JSZip constructor (see #93).
  • update zlibjs to v0.2.0.

@dduponchel
Copy link
Collaborator Author

The saucelabs tests also passed.

@@ -1,3 +1,7 @@
### v2.2.0, 2014-02-25
- make the ```new``` operator optional before the ```JSZip``` constructor (see [#93](https://github.com/Stuk/jszip/pull/93)).
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only need one "`" before and after, here

Stuk added a commit that referenced this pull request Feb 26, 2014
@Stuk Stuk merged commit 3df3b40 into Stuk:master Feb 26, 2014
@dduponchel dduponchel deleted the release_v2.2.0 branch February 26, 2014 06:36
@Mithgol
Copy link
Contributor

Mithgol commented Feb 26, 2014

@Stuk Would you npm publish? Otherwise npm says (currently) that jszip package still has version 2.1.1.

@dduponchel
Copy link
Collaborator Author

@calvinmetcalf handles the npm package.

@Mithgol
Copy link
Contributor

Mithgol commented Feb 26, 2014

Ah.

@calvinmetcalf
Copy link
Contributor

done

@dduponchel
Copy link
Collaborator Author

Thanks :)

@Mithgol
Copy link
Contributor

Mithgol commented Feb 26, 2014

Thank you.

@Stuk
Copy link
Owner

Stuk commented Feb 27, 2014

@calvinmetcalf just so I know, to publish do you just run npm publish inside the jszip directory, or do you do some other steps?

@calvinmetcalf
Copy link
Contributor

checkout x && npm publish

with x being the tag so 'v2.2.0' most recently

On Thu, Feb 27, 2014 at 3:16 PM, Stuart Knightley
[email protected]:

@calvinmetcalf https://github.com/calvinmetcalf just so I know, to
publish do you just run npm publish inside the jszip directory, or do you
do some other steps?

Reply to this email directly or view it on GitHubhttps://github.com//pull/106#issuecomment-36286224
.

-Calvin W. Metcalf

@Stuk
Copy link
Owner

Stuk commented Feb 27, 2014

kk, great. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants