This repository has been archived by the owner on May 19, 2024. It is now read-only.
[WEAV-000] 채팅 메시지 코루틴 리팩터링 #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dojinyou
reviewed
Apr 18, 2024
...src/main/kotlin/com/studentcenter/weave/bootstrap/chat/controller/ChatMessageEventHandler.kt
Outdated
Show resolved
Hide resolved
waterfogSW
commented
Apr 18, 2024
...src/main/kotlin/com/studentcenter/weave/bootstrap/chat/controller/ChatMessageEventHandler.kt
Outdated
Show resolved
Hide resolved
waterfogSW
commented
Apr 18, 2024
.../common/src/main/kotlin/com/studentcenter/weave/support/common/functions/CoroutineSupport.kt
Outdated
Show resolved
Hide resolved
dojinyou
reviewed
Apr 18, 2024
domain/src/main/kotlin/com/studentcenter/weave/domain/chat/entity/ChatMessage.kt
Outdated
Show resolved
Hide resolved
waterfogSW
changed the title
|
dojinyou
approved these changes
Apr 19, 2024
|
|
||
| fun count(): Int = bucket.size | ||
|
|
||
| fun clear() = bucket.clear() |
There was a problem hiding this comment.
p4) 리팩토링 의견 요거 저희 추상화해버릴까요? spy repo는 다 필요해보여서 ㅋㅋ 혹은 test용으로 beforeTest / afterTest 같은 메서드 만들어서 콜해도 되구?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
graph TD A[SendChatMessageService] -->|publish| B(ChatMessageRedisProducer) B -->|이벤트 발행| C{Redis} C -->|이벤트 수신| D(ChatMessageRedisConsumer) D -->|publishEvent| E(ApplicationEventPublisher) E -->|handleChatMessage| F[ChatMessageHandler] F -->|convertAndSend| G(SimpMessageSendingOperations) G -->|브로드캐스트| H((User)) A -->|save| I(ChatMessageRepository)